Skip to content

[PWGEM] Update Configurables for ML based photon cuts #14593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhemmer-cern merged 2 commits into from
Jan 22, 2026
Merged

[PWGEM] Update Configurables for ML based photon cuts #14593

mhemmer-cern merged 2 commits into from
Jan 22, 2026
+177 −38

Conversation

@ikantak
Copy link
Contributor

@ikantak ikantak commented Jan 22, 2026

  • Remove the labeledArray configurable for specifying the ML based cuts location to three different Configurable (cut location, bin labels and cut labels) so that the number of cuts can be varied
  • add Configurable for selecting centrality variable (CentFT0M, CentFT0C or CentFT0A) for 2D ML model selection

Update Configurable for ML based photon cuts and add Configurable for…
eb1299e 
… selecting centrality variable for 2D ML model selection.
@github-actions github-actions bot added the pwgem label Jan 22, 2026
@github-actions
Copy link

github-actions bot commented Jan 22, 2026 •
edited
Loading

O2 linter results: ❌ 231 errors, ⚠️ 489 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update Configurables for ML based photon cuts [PWGEM] Update Configurables for ML based photon cuts Jan 22, 2026
@ikantak ikantak marked this pull request as ready for review January 22, 2026 17:22
mhemmer-cern
mhemmer-cern previously approved these changes Jan 22, 2026
View reviewed changes
Copy link
Collaborator

@mhemmer-cern mhemmer-cern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhemmer-cern mhemmer-cern enabled auto-merge (squash) January 22, 2026 17:50
auto-merge was automatically disabled January 22, 2026 19:23

Head branch was pushed to by a user without write access

@mhemmer-cern mhemmer-cern enabled auto-merge (squash) January 22, 2026 19:26
@mhemmer-cern mhemmer-cern merged commit 790b864 into AliceO2Group:master Jan 22, 2026
20 of 22 checks passed
@alibuild
Copy link
Collaborator

alibuild commented Jan 22, 2026

Error while checking build/O2Physics/o2 for eb1299e at 2026-01-22 21:45:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:53:9: error: 'V0PhotonCandidate::centFT0A' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error:   'float V0PhotonCandidate::centFT0C' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error: 'V0PhotonCandidate::centFT0C' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:51:9: error:   'float V0PhotonCandidate::centFT0M' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:53:9: error: 'V0PhotonCandidate::centFT0A' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error:   'float V0PhotonCandidate::centFT0C' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error: 'V0PhotonCandidate::centFT0C' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:51:9: error:   'float V0PhotonCandidate::centFT0M' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:53:9: error: 'V0PhotonCandidate::centFT0A' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error:   'float V0PhotonCandidate::centFT0C' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error: 'V0PhotonCandidate::centFT0C' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:51:9: error:   'float V0PhotonCandidate::centFT0M' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:53:9: error: 'V0PhotonCandidate::centFT0A' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error:   'float V0PhotonCandidate::centFT0C' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:52:9: error: 'V0PhotonCandidate::centFT0C' will be initialized after [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:51:9: error:   'float V0PhotonCandidate::centFT0M' [-Werror=reorder]
/sw/SOURCES/O2Physics/14593-slc9_x86-64/0/PWGEM/PhotonMeson/Core/V0PhotonCandidate.h:100:3: error:   when initialized here [-Werror=reorder]
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhemmer-cern mhemmer-cern mhemmer-cern approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@m-c-danisch m-c-danisch Awaiting requested review from m-c-danisch m-c-danisch is a code owner

@novitzky novitzky Awaiting requested review from novitzky novitzky is a code owner

@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Assignees

No one assigned

Labels

pwgem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikantak @alibuild @mhemmer-cern